Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang to 1.10 #2582

Merged
merged 1 commit into from
May 22, 2018
Merged

Conversation

thaJeztah
Copy link
Member

@stevvooe
Copy link
Collaborator

LGTM

@thaJeztah
Copy link
Member Author

Tests keep failing on x509: certificate has expired or is not yet valid 😞

@thaJeztah
Copy link
Member Author

Ah hm... looking at https://github.com/docker/distribution/blob/11406050aff4a727bd6d3f427d04eac914e22886/contrib/docker-integration/nginx/ssl/registry-ca%2Bca.pem

Certificate Information:
Common Name: QuickTLS
Organization: QuickTLS
Valid From: May 26, 2015
Valid To: May 10, 2018
Issuer: QuickTLS, QuickTLS
Serial Number: 32c74f5a82c0b28fed20ebcb93c47fb0

@dmcgowan
Copy link
Collaborator

Opened #2594 to fix tests

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #2582 into master will decrease coverage by 9.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2582      +/-   ##
==========================================
- Coverage   60.87%   51.26%   -9.61%     
==========================================
  Files         129      129              
  Lines       11876    11876              
==========================================
- Hits         7229     6088    -1141     
- Misses       3744     5027    +1283     
+ Partials      903      761     -142
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.39% <0%> (-68.67%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-56.91%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.14%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.15% <0%> (-50.98%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️
...egistry/storage/cache/cachedblobdescriptorstore.go 56.25% <0%> (+10.41%) ⬆️
registry/storage/cache/cache.go 75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed42a49...7f02f9e. Read the comment docs.

Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit f0cc927 into distribution:master May 22, 2018
@thaJeztah thaJeztah deleted the bump-golang-1.10 branch May 22, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants