Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gorilla/context from vendor.conf #2556

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

justincormack
Copy link
Collaborator

@justincormack justincormack commented Mar 26, 2018

This has been unused since we switched to Go context. It is only
a dependency of gorilla/mux if built on pre 1.7 Go.

Signed-off-by: Justin Cormack [email protected]

This has been unused since we switched to Go context.

Signed-off-by: Justin Cormack <[email protected]>
@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #2556 into master will decrease coverage by 9.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2556      +/-   ##
=========================================
- Coverage   60.87%   51.2%   -9.67%     
=========================================
  Files         129     129              
  Lines       11876   11876              
=========================================
- Hits         7229    6081    -1148     
- Misses       3744    5032    +1288     
+ Partials      903     763     -140
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.39% <0%> (-68.67%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-56.91%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.14%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.15% <0%> (-50.98%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bef41...fb7b0dd. Read the comment docs.

@dmcgowan
Copy link
Collaborator

LGTM

@dmcgowan dmcgowan merged commit 83389a1 into distribution:master Mar 27, 2018
@justincormack justincormack deleted the fewer-gorillas branch May 16, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants