Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: delete right size attribute #2549

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

miminar
Copy link
Contributor

@miminar miminar commented Mar 13, 2018

No description provided.

Signed-off-by: Michal Minář <[email protected]>
@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #2549 into master will decrease coverage by 9.67%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
- Coverage   60.83%   51.16%   -9.68%     
==========================================
  Files         129      129              
  Lines       11864    11864              
==========================================
- Hits         7218     6070    -1148     
- Misses       3743     5031    +1288     
+ Partials      903      763     -140
Impacted Files Coverage Δ
registry/storage/cache/redis/redis.go 0% <0%> (ø) ⬆️
registry/storage/driver/gcs/gcs.go 0.39% <0%> (-68.67%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-56.91%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.14%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.15% <0%> (-50.98%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fca8d6...492844e. Read the comment docs.

@dmcgowan
Copy link
Collaborator

LGTM

@stevvooe I see a comment in this file related to size -> length, can you take a look at this one as well

@stevvooe
Copy link
Collaborator

LGTM

@stevvooe stevvooe merged commit 34c706e into distribution:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants