Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore path not found error when look up tags #2520

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

ywk253100
Copy link
Contributor

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "ignore_path_not_found_error" [email protected]:ywk253100/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354250592
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

Merging #2520 into master will decrease coverage by 9.7%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2520      +/-   ##
==========================================
- Coverage   60.83%   51.12%   -9.71%     
==========================================
  Files         129      129              
  Lines       11826    11828       +2     
==========================================
- Hits         7194     6047    -1147     
- Misses       3731     5019    +1288     
+ Partials      901      762     -139
Impacted Files Coverage Δ
registry/storage/tagstore.go 71.15% <45.45%> (-1.85%) ⬇️
registry/storage/driver/gcs/gcs.go 0.39% <0%> (-68.67%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-56.91%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.14%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.15% <0%> (-50.98%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️
configuration/configuration.go 68.33% <0%> (ø) ⬆️
registry/registry.go 3.2% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d707ea2...005c6e0. Read the comment docs.

@stevvooe
Copy link
Collaborator

stevvooe commented Feb 9, 2018

LGTM

@dmcgowan
Copy link
Collaborator

dmcgowan commented Feb 9, 2018

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants