-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #2484
Update CONTRIBUTING.md #2484
Conversation
Please sign your commits following these rules: $ git clone -b "patch-1" [email protected]:perlun/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Fixed the headers. They were rendering incorrectly on GitHub for some weird reason; I copied the strings and rewrote the ## characters at the beginning and now they render as they should. Signed-off-by: Per Lundberg <[email protected]>
@GordonTheTurtle Done. Bonus points for the excellent instructions on how to clone my fork, amend the commit etc. 👍 Makes it effortless really. |
Codecov Report
@@ Coverage Diff @@
## master #2484 +/- ##
=========================================
- Coverage 61.42% 51.6% -9.83%
=========================================
Files 128 128
Lines 11685 11685
=========================================
- Hits 7178 6030 -1148
- Misses 3615 4903 +1288
+ Partials 892 752 -140
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, thanks! guess there was a different white-space character in between (a tab?)
LGTM
ping @stevvooe for the merge (I don't have permissions to merge due to codecov complaining 😅) |
LGTM codecov is the worst. |
Fixed the headers. They were rendering incorrectly on GitHub for some weird reason; I copied the strings and rewrote the ## characters at the beginning and now they render as they should.
Rendered version