Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #2484

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Update CONTRIBUTING.md #2484

merged 1 commit into from
Jan 3, 2018

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Dec 29, 2017

Fixed the headers. They were rendering incorrectly on GitHub for some weird reason; I copied the strings and rewrote the ## characters at the beginning and now they render as they should.

Rendered version

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" [email protected]:perlun/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Fixed the headers. They were rendering incorrectly on GitHub for some weird reason; I copied the strings and rewrote the ## characters at the beginning and now they render as they should.

Signed-off-by: Per Lundberg <[email protected]>
@perlun
Copy link
Contributor Author

perlun commented Dec 29, 2017

@GordonTheTurtle Done. Bonus points for the excellent instructions on how to clone my fork, amend the commit etc. 👍 Makes it effortless really.

@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #2484 into master will decrease coverage by 9.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2484      +/-   ##
=========================================
- Coverage   61.42%   51.6%   -9.83%     
=========================================
  Files         128     128              
  Lines       11685   11685              
=========================================
- Hits         7178    6030    -1148     
- Misses       3615    4903    +1288     
+ Partials      892     752     -140
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.57% <0%> (-56.23%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.4%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f411848...eaa90a3. Read the comment docs.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks! guess there was a different white-space character in between (a tab?)

LGTM

@thaJeztah
Copy link
Member

ping @stevvooe for the merge (I don't have permissions to merge due to codecov complaining 😅)

@stevvooe
Copy link
Collaborator

stevvooe commented Jan 3, 2018

LGTM

codecov is the worst.

@stevvooe stevvooe merged commit db0bc08 into distribution:master Jan 3, 2018
@perlun perlun deleted the patch-1 branch January 3, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants