cmd/digest: import crypto algorithms #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "algo-import" [email protected]:zhouhaibing089/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
the digest cli does not work if we do not import this two packages, tested in go1.9. basically, we have to make several algorithms to be available by calling crypto.RegisterHash in init functions. Signed-off-by: zhouhaibing089 <[email protected]>
zhouhaibing089
force-pushed
the
algo-import
branch
from
99ed574
to
d662081
Compare
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
==========================================
- Coverage 60.32% 50.74% -9.59%
==========================================
Files 126 126
Lines 14436 14436
==========================================
- Hits 8708 7325 -1383
- Misses 4844 6367 +1523
+ Partials 884 744 -140
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the digest cli does not work if we do not import this two packages,
tested in go1.9. basically, we have to make several algorithms to
be available by calling crypto.RegisterHash in init functions.