context: remove definition of Context #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevvooe
force-pushed
the
remove-context-type
branch
from
c6acb91
to
ecb4a42
Compare
Back in the before time, the best practices surrounding usage of Context weren't quite worked out. We defined our own type to make usage easier. As this packaged was used elsewhere, it make it more and more challenging to integrate with the forked `Context` type. Now that it is available in the standard library, we can just use that one directly. To make usage more consistent, we now use `dcontext` when referring to the distribution context package. Signed-off-by: Stephen J Day <[email protected]>
stevvooe
force-pushed
the
remove-context-type
branch
from
ecb4a42
to
9c88801
Compare
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2360 +/- ##
=========================================
- Coverage 60.23% 50.63% -9.6%
=========================================
Files 126 126
Lines 14390 14396 +6
=========================================
- Hits 8668 7290 -1378
- Misses 4834 6358 +1524
+ Partials 888 748 -140
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in the before time, the best practices surrounding usage of Context
weren't quite worked out. We defined our own type to make usage easier.
As this packaged was used elsewhere, it make it more and more
challenging to integrate with the forked
Contexttype. Now that it isavailable in the standard library, we can just use that one directly.
To make usage more consistent, we now use
dcontextwhen referring tothe distribution context package.
Signed-off-by: Stephen J Day [email protected]