Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function #2275

Merged
merged 1 commit into from
May 16, 2017
Merged

Remove unused function #2275

merged 1 commit into from
May 16, 2017

Conversation

IamBusy
Copy link
Contributor

@IamBusy IamBusy commented May 16, 2017

I think it's a good habitat to keep code clean. So I removed the unused function hasCode.

Signed-off-by: william wei [email protected]

Signed-off-by: william wei <[email protected]>
@codecov
Copy link

codecov bot commented May 16, 2017

Codecov Report

Merging #2275 into master will decrease coverage by 10.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2275       +/-   ##
===========================================
- Coverage   61.59%   51.51%   -10.08%     
===========================================
  Files         125      125               
  Lines       11405    11402        -3     
===========================================
- Hits         7025     5874     -1151     
- Misses       3495     4782     +1287     
+ Partials      885      746      -139
Impacted Files Coverage Δ
registry/storage/driver/s3-goamz/s3.go 0.5% <ø> (-50.88%) ⬇️
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.57% <0%> (-56.23%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-13.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce936a8...37ca688. Read the comment docs.

@dmcgowan
Copy link
Collaborator

LGTM

@dmcgowan dmcgowan merged commit 9098f84 into distribution:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants