Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #htpasswd link #2264

Merged
merged 1 commit into from
May 4, 2017
Merged

Fixed #htpasswd link #2264

merged 1 commit into from
May 4, 2017

Conversation

luislobo
Copy link
Contributor

@luislobo luislobo commented May 4, 2017

Fixed #htpasswd link

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" [email protected]:luislobo/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Fixed #htpasswd link

Signed-off-by: Luis Lobo Borobia <[email protected]>
@codecov
Copy link

codecov bot commented May 4, 2017

Codecov Report

Merging #2264 into master will decrease coverage by 10.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #2264       +/-   ##
==========================================
- Coverage   61.56%   51.5%   -10.07%     
==========================================
  Files         125     125               
  Lines       11405   11405               
==========================================
- Hits         7022    5874     -1148     
- Misses       3497    4785     +1288     
+ Partials      886     746      -140
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.57% <0%> (-56.23%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-50.88%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d78247...212f47c. Read the comment docs.

@stevvooe
Copy link
Collaborator

stevvooe commented May 4, 2017

LGTM

@stevvooe stevvooe merged commit 7cc8e70 into distribution:master May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants