DOC:configuration.md: Change description of interval. #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masataka Mizukoshi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2262 +/- ##
==========================================
- Coverage 61.56% 51.5% -10.07%
==========================================
Files 125 125
Lines 11405 11405
==========================================
- Hits 7022 5874 -1148
- Misses 3497 4785 +1288
+ Partials 886 746 -140
Continue to review full report at Codecov.
|
|
Sorry I accidentally closed this request. |
stevvooe
reviewed
May 4, 2017
docs/configuration.md
Outdated
| threshold: 5 | ||
| backoff: 1000 | ||
| backoff: 20s |
There was a problem hiding this comment.
20s is probably too high. I would say 5-10s would be better.
There was a problem hiding this comment.
Okey I see. Thank you for comment. I'll modify it.
|
Not sure how this got this way. Here is the development configuration for examples of correct values. @dmcgowan PTAL |
Signed-off-by: Masataka Mizukoshi <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masataka Mizukoshi [email protected]
I've modified the
docs/configuration.md.The notifications
intervalandtimeoutwas deprecated values.And Fixed some configuration related with timeout/interval.
See this issue #2231