Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference: allow more than 1 digest algorithm separator #2253

Merged

Conversation

stevvooe
Copy link
Collaborator

This updates the grammar to allow more than one digest algorithm
separator, matching the regular expression and intended grammar.

Signed-off-by: Stephen J Day [email protected]

This updates the grammar to allow more than one digest algorithm
separator, matching the regular expression and intended grammar.

Signed-off-by: Stephen J Day <[email protected]>
@codecov
Copy link

codecov bot commented Apr 24, 2017

Codecov Report

Merging #2253 into master will decrease coverage by 10.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2253       +/-   ##
===========================================
- Coverage   61.61%   51.54%   -10.07%     
===========================================
  Files         125      125               
  Lines       11395    11395               
===========================================
- Hits         7021     5874     -1147     
- Misses       3489     4776     +1287     
+ Partials      885      745      -140
Impacted Files Coverage Δ
reference/reference.go 80.6% <ø> (ø) ⬆️
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-57.23%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.59% <0%> (-56.33%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-50.88%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e06c6...3da015f. Read the comment docs.

@dmcgowan
Copy link
Collaborator

LGTM

@dmcgowan dmcgowan merged commit e85ef3c into distribution:master Apr 25, 2017
@stevvooe stevvooe deleted the allow-more-digest-alg-separators branch April 25, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants