[CI] Fetch origin before diffing #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that origin/master may not be up to date in CircleCI checkouts. Fetch origin so that diffing for the vendor check can be done correctly. Note that this doesn't help the case of PRs against branches other than master, but the worst case is that those will waste a few seconds doing unnecessary vendor validation. Since those PRs are relatively rare, that seems fine. Signed-off-by: Aaron Lehmann <[email protected]>
aaronlehmann
force-pushed
the
fetch-origin
branch
from
032aa2d
to
2f72889
Compare
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
===========================================
- Coverage 61.61% 51.54% -10.07%
===========================================
Files 125 125
Lines 11395 11395
===========================================
- Hits 7021 5874 -1147
- Misses 3489 4776 +1287
+ Partials 885 745 -140
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that origin/master may not be up to date in CircleCI
checkouts. Fetch origin so that diffing for the vendor check can be done
correctly.
Note that this doesn't help the case of PRs against branches other than
master, but the worst case is that those will waste a few seconds doing
unnecessary vendor validation. Since those PRs are relatively rare, that
seems fine.