Fix vendor validation #2217
Merged
Fix vendor validation #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dep-validate target appears to never get invoked. In the CircleCI build environment, "master" points to the commit under test. The circle.yml fragment needs to compare again "origin/master" instead. Signed-off-by: Aaron Lehmann <[email protected]>
aaronlehmann
force-pushed
the
fix-vendor-validation
branch
from
4098992
to
f6c6245
Compare
Codecov Report
@@ Coverage Diff @@
## master #2217 +/- ##
===========================================
- Coverage 61.74% 51.72% -10.02%
===========================================
Files 125 125
Lines 11452 11452
===========================================
- Hits 7071 5924 -1147
- Misses 3495 4782 +1287
+ Partials 886 746 -140
Continue to review full report at Codecov.
|
|
Nice find. LGTM, proof of fix at https://circleci.com/gh/docker/distribution/5103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dep-validate target appears to never get invoked. In the CircleCI
build environment, "master" points to the commit under test. The
circle.yml fragment needs to compare again "origin/master" instead.