Use errors.New() to output the error message and fix some typos #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2195 +/- ##
==========================================
- Coverage 61.73% 51.88% -9.86%
==========================================
Files 125 119 -6
Lines 11450 11200 -250
==========================================
- Hits 7069 5811 -1258
- Misses 3495 4662 +1167
+ Partials 886 727 -159
Continue to review full report at Codecov.
|
Windfarer
reviewed
Feb 16, 2017
configuration/configuration.go
Outdated
| @@ -474,7 +475,7 @@ func (storage Storage) MarshalYAML() (interface{}, error) { | |||
| // Auth defines the configuration for registry authorization. | |||
| type Auth map[string]Parameters | |||
|
|
|||
| // Type returns the auth type, such as htpasswd or token | |||
| // Type returns the auth type, such as passwd or token | |||
There was a problem hiding this comment.
oh, I'm so sorry! I will update it.
fate-grand-order
force-pushed
the
fixed
branch
from
4f97629
to
18d21dc
Compare
dmcgowan
reviewed
Feb 17, 2017
errors.go
Outdated
| @@ -77,7 +77,7 @@ func (err ErrManifestUnknownRevision) Error() string { | |||
| type ErrManifestUnverified struct{} | |||
|
|
|||
| func (ErrManifestUnverified) Error() string { | |||
| return fmt.Sprintf("unverified manifest") | |||
| return fmt.Sprint("unverified manifest") | |||
There was a problem hiding this comment.
just return "unverified manifest"
There was a problem hiding this comment.
ok, the PR has updated. @dmcgowan
Signed-off-by: fate-grand-order <[email protected]>
fate-grand-order
force-pushed
the
fixed
branch
from
18d21dc
to
6a8e2ca
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use errors.New() directly to output the error message and fix some typos I found.
Signed-off-by: fate-grand-order [email protected]