Expose DomainRegexp from reference
#2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is based on: moby/moby#30746 (comment) The goal is to reuse the `DomainRegexp` in docker to check for `<host>:<port>` pattern. Signed-off-by: Yong Tang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
- Coverage 57.86% 51.24% -6.63%
==========================================
Files 125 125
Lines 11446 11446
==========================================
- Hits 6623 5865 -758
- Misses 3988 4835 +847
+ Partials 835 746 -89
Continue to review full report at Codecov.
|
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is based on:
moby/moby#30746 (comment)
The goal is to reuse the
DomainRegexpin docker to check for<host>:<port>pattern./cc @dmcgowan @aaronlehmann not sure this is the best way to handle it so feel free to close the PR or provide any suggestions.
Signed-off-by: Yong Tang [email protected]