Fix recursion with digest String #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
force-pushed
the
fix-digest-reference-recursion
branch
from
6d18fb5
to
1d56728
Compare
|
LGTM |
Update check for equal references to call the String method Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
dmcgowan
force-pushed
the
fix-digest-reference-recursion
branch
from
1d56728
to
69bdac7
Compare
|
Updated to check string value against equivalent rather than string of expected |
Current coverage is 51.23% (diff: 100%)@@ master #2167 diff @@
==========================================
Files 125 125
Lines 11447 11447
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 7007 5865 -1142
- Misses 3552 4836 +1284
+ Partials 888 746 -142
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update check for equal references to call the
StringmethodCloses #2163