Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[carry #2153] Correct the variable name #2156

Merged

Conversation

dmcgowan
Copy link
Collaborator

Sorry @Helen-Xie I messed up the other PR when I tried to rebase it and it closed. The rebase was needed to get circleci to pass (apparently it doesn't merge to master before running tests).

Carried from #2153

@dmcgowan dmcgowan changed the title Correct the variable name [carry #2153] Correct the variable name Jan 18, 2017
@codecov-io
Copy link

codecov-io commented Jan 18, 2017

Current coverage is 51.21% (diff: 62.50%)

Merging #2156 into master will decrease coverage by 10.02%

@@             master      #2156   diff @@
==========================================
  Files           125        125           
  Lines         11436      11436           
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
==========================================
- Hits           7004       5857   -1147   
- Misses         3545       4833   +1288   
+ Partials        887        746    -141   

Powered by Codecov. Last update 954b4e8...9085601

@dmcgowan
Copy link
Collaborator Author

LGTM

@dmcgowan dmcgowan merged commit c91563f into distribution:master Jan 18, 2017
@Helen-Xie
Copy link
Contributor

That’s OK. @dmcgowan Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants