Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-go dependency to 1.6.12 #2154

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

justinsb
Copy link
Contributor

1.6.12 = c6fc52983ea2375810aa38ddb5370e9cdf611716

@codecov-io
Copy link

codecov-io commented Jan 18, 2017

Current coverage is 51.21% (diff: 100%)

Merging #2154 into master will decrease coverage by 10.02%

@@             master      #2154   diff @@
==========================================
  Files           125        125           
  Lines         11436      11436           
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
==========================================
- Hits           7004       5857   -1147   
- Misses         3545       4833   +1288   
+ Partials        887        746    -141   

Powered by Codecov. Last update 954b4e8...9b4f24f

@dmcgowan
Copy link
Collaborator

Please rebase this, just merged a PR which updates to 1.6.9, so resolving vendor.conf and revendoring should do the trick. Trying to track the updates we might be pulling in, is there anything in particular we should highlight in the update from 1.6.9 to 1.6.12?

1.6.12 = c6fc52983ea2375810aa38ddb5370e9cdf611716

Signed-off-by: Justin Santa Barbara <[email protected]>
@justinsb
Copy link
Contributor Author

@dmcgowan thanks - rebased and fixed.

Looking at the diff, there isn't much between 1.6.9 and 1.6.12. There are some optimizations I would characterize as micro-optimizations, and a few endpoint definitions. I wasn't aware of the concurrent pull to 1.6.9 and that is new enough for me. I'm happy to either close (or for you to close) this PR, or if we like to stay on the latest version it's here if you need it :-)

@dmcgowan
Copy link
Collaborator

@justinsb thanks for looking into that. I would rather just do the update now to get on the latest since it is early enough in the next release cycle to give people a chance to test. The previous update to 1.6.9 was far more risky so will go ahead and merge this in when tests pass.

@dmcgowan
Copy link
Collaborator

LGTM

@dmcgowan dmcgowan added this to the Registry/2.7 milestone Jan 18, 2017
@dmcgowan dmcgowan merged commit ea4b89d into distribution:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants