Change DELETE action from "*" to "delete" #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With token authentication, requiring the "*" action for DELETE requests makes it impossible to administratively lock a repository against pushes and pulls but still allow deletion. This change adds a new "delete" action for DELETE requests to make that possible. Signed-off-by: Noah Treuhaft <[email protected]>
|
Just saw #2120. |
|
I'm reopening this in case it's preferable to #2120. |
Current coverage is 51.21% (diff: 100%)@@ master #2121 diff @@
==========================================
Files 129 129
Lines 11416 11416
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6991 5847 -1144
- Misses 3534 4820 +1286
+ Partials 891 749 -142
|
|
@nwt Need to confirm that |
Test that an auth token with the "*" action is allowed any action on its resource. Signed-off-by: Noah Treuhaft <[email protected]>
|
@jlhawn PTAL |
|
SGTM |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With token authentication, requiring the "*" action for DELETE requests
makes it impossible to administratively lock a repository against pushes
and pulls but still allow deletion. This change adds a new "delete"
action for DELETE requests to make that possible.