digest: remove stuttering ParseDigest function #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen J Day <[email protected]>
|
Hold off on merging this for a bit... |
Signed-off-by: Stephen J Day <[email protected]>
|
Alright, please merge when building! |
|
LGTM |
|
LGTM, but note that this change will have to be coordinated with docker/docker and docker/swarmkit, which both use this function. The moment swarmkit vendors a new distribution and fixes its calls to this function, docker will need to as well, otherwise swarmkit won't be vendorable anymore. It's probably worth creating PRs for both docker/docker and docker/swarmkit and merging them around the same time. |
|
This change does not remove the old function, so don't think there should be any difficulty vendoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day [email protected]