Format configuration.md with code fences to avoid render issues #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaofnfernandes
force-pushed
the
fix-configuration.md
branch
from
81e2c30
to
7a000ca
Compare
|
@dmcgowan can you check if this makes sense? |
dmcgowan
requested changes
Dec 15, 2016
| storage: | ||
| filesystem: | ||
| rootdirectory: /var/lib/registry | ||
| maxthreads: 100 |
There was a problem hiding this comment.
spacing was messed up before with tabs, can you align this with rootdirectory
Signed-off-by: Joao Fernandes <[email protected]>
joaofnfernandes
force-pushed
the
fix-configuration.md
branch
from
7a000ca
to
a24f2a6
Compare
|
Should be fixed |
|
LGTM Please submit PRs for the other branches. |
dmcgowan
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page is being pulled into docs.docker.com and sometimes not rendering properly. I think Jekyll doesn't really like mixing markdown and html syntax, so I've changed the code samples to use fences instead of spaces. That seems to make Jekyll happier and infer better markdown and html blocks.
The last table in the document was also not closing and html tag which was causing rendering issues too.
The docs are currently pulling from
releases/2.5, so if you want I can also submit PRs againstreleases/2.5andreleases/2.6.