Replace godep with vndr #2080
Merged
Replace godep with vndr #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vndr has a simpler configuration and allows pointing to forked packages. Additionally other docker projects are now using vndr making vendoring in distribution more consistent. Updates letsencrypt to use fork. No longer uses sub-vendored packages. Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
Current coverage is 51.08% (diff: 100%)@@ master #2080 diff @@
==========================================
Files 128 128
Lines 11396 11396
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6823 5822 -1001
- Misses 3710 4824 +1114
+ Partials 863 750 -113
|
Re-enable dependency validation using vndr instead of godep Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)
|
cc @LK4D4 |
|
I'm all for this :) |
|
Noticed that a |
|
It is a remove, binary removals show up in a confusing manner in the file list diff --git a/vendor/rsc.io/letsencrypt/vendor/gopkg.in/square/go-jose.v1/json/testdata/code.json.gz b/vendor/rsc.io/letsencrypt/vendor/gopkg.in/square/go-jose.v1/json/testdata/code.json.gz
deleted file mode 100644
index 0e2895b..0000000
Binary files a/vendor/rsc.io/letsencrypt/vendor/gopkg.in/square/go-jose.v1/json/testdata/code.json.gz and /dev/null differ
|
|
@aaronlehmann I see what you are talking about, looks like a Github bug. In the file list shows up as red, but in the other list shows up as green....
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vndr has a simpler configuration and allows pointing to forked packages. Additionally other docker projects are now using vndr making vendoring in distribution more consistent.
Updates letsencrypt to use fork.
No longer uses sub-vendored packages.
See https://github.com/lk4d4/vndr