Adding utility functions - IsNameOnly and EnsureTagged #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 51.22% (diff: 0.00%)@@ master #2062 diff @@
==========================================
Files 126 128 +2
Lines 11308 11322 +14
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6944 5800 -1144
- Misses 3476 4775 +1299
+ Partials 888 747 -141
|
|
Ping @dmcgowan @aaronlehmann |
|
This does have some overlap with what will be added #1778. Would prefer matching the interface approved in that PR for the new functions. Not going to get that merged until after 2.6 since it has a large PR needed to go along with it in the engine. |
|
@dmcgowan cool! let me update the PR to match your changes. Hopefully the changes in this PR are acceptable for the next vendor. |
|
@nishanttotla just include the 2 functions you need, should be a simple vendor |
Signed-off-by: Nishant Totla <[email protected]>
nishanttotla
force-pushed
the
with-default-tag
branch
from
f3afe56
to
2caeb61
Compare
|
@dmcgowan I've updated the PR. Let me know if this is acceptable. |
|
LGTM Can you please update the PR description to match the changed function name? |
nishanttotla
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsNameOnlyandEnsureTaggedaren't present indocker/docker/reference, but useful trivial utility functions. This also reduces the gap between the the Docker reference package and the one in this repo.Signed-off-by: Nishant Totla [email protected]