schema1: Validate descriptors in AppendReference

If the digest is malformed, it will cause a panic when building the manifest. Signed-off-by: Aaron Lehmann <[email protected]>
distribution · Nov 30, 2016 · ec5fa1f · ec5fa1f
1 parent bf27f26
commit ec5fa1f
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/manifest/schema1/config_builder.go b/manifest/schema1/config_builder.go
@@ -240,8 +240,13 @@ func (mb *configManifestBuilder) emptyTar(ctx context.Context) (digest.Digest, e
 
 // AppendReference adds a reference to the current ManifestBuilder
 func (mb *configManifestBuilder) AppendReference(d distribution.Describable) error {
-	// todo: verification here?
-	mb.descriptors = append(mb.descriptors, d.Descriptor())
+	descriptor := d.Descriptor()
+
+	if err := descriptor.Digest.Validate(); err != nil {
+		return err
+	}
+
+	mb.descriptors = append(mb.descriptors, descriptor)
 	return nil
 }