diff --git a/cmd/compose/compose.go b/cmd/compose/compose.go index 04f4ea88dd4..d9a3c821a77 100644 --- a/cmd/compose/compose.go +++ b/cmd/compose/compose.go @@ -26,6 +26,7 @@ import ( "strings" "syscall" + "github.com/compose-spec/compose-go/dotenv" buildx "github.com/docker/buildx/util/progress" "github.com/docker/cli/cli/command" @@ -472,7 +473,7 @@ func setEnvWithDotEnv(prjOpts *ProjectOptions) error { return err } - envFromFile, err := cli.GetEnvFromFile(composegoutils.GetAsEqualsMap(os.Environ()), workingDir, options.EnvFiles) + envFromFile, err := dotenv.GetEnvFromFile(composegoutils.GetAsEqualsMap(os.Environ()), workingDir, options.EnvFiles) if err != nil { return err } diff --git a/cmd/compose/up.go b/cmd/compose/up.go index 9eb25485533..77231e91308 100644 --- a/cmd/compose/up.go +++ b/cmd/compose/up.go @@ -21,9 +21,8 @@ import ( "fmt" "time" - "github.com/docker/compose/v2/cmd/formatter" - "github.com/compose-spec/compose-go/types" + "github.com/docker/compose/v2/cmd/formatter" "github.com/spf13/cobra" "github.com/docker/compose/v2/pkg/api" @@ -164,17 +163,31 @@ func runUp(ctx context.Context, streams api.Streams, backend api.Service, create consumer = formatter.NewLogConsumer(ctx, streams.Out(), streams.Err(), !upOptions.noColor, !upOptions.noPrefix, upOptions.timestamp) } - attachTo := services + attachTo := utils.Set[string]{} if len(upOptions.attach) > 0 { - attachTo = upOptions.attach + attachTo.AddAll(upOptions.attach...) } if upOptions.attachDependencies { - attachTo = project.ServiceNames() + if err := project.WithServices(attachTo.Elements(), func(s types.ServiceConfig) error { + if s.Attach == nil || *s.Attach { + attachTo.Add(s.Name) + } + return nil + }); err != nil { + return err + } } if len(attachTo) == 0 { - attachTo = project.ServiceNames() + if err := project.WithServices(services, func(s types.ServiceConfig) error { + if s.Attach == nil || *s.Attach { + attachTo.Add(s.Name) + } + return nil + }); err != nil { + return err + } } - attachTo = utils.Remove(attachTo, upOptions.noAttach...) + attachTo.RemoveAll(upOptions.noAttach...) create := api.CreateOptions{ Services: services, @@ -198,7 +211,7 @@ func runUp(ctx context.Context, streams api.Streams, backend api.Service, create Start: api.StartOptions{ Project: project, Attach: consumer, - AttachTo: attachTo, + AttachTo: attachTo.Elements(), ExitCodeFrom: upOptions.exitCodeFrom, CascadeStop: upOptions.cascadeStop, Wait: upOptions.wait, diff --git a/go.mod b/go.mod index 303aba95a76..95b44fa0296 100644 --- a/go.mod +++ b/go.mod @@ -6,7 +6,7 @@ require ( github.com/AlecAivazis/survey/v2 v2.3.7 github.com/Microsoft/go-winio v0.6.1 github.com/buger/goterm v1.0.4 - github.com/compose-spec/compose-go v1.15.1 + github.com/compose-spec/compose-go v1.16.0 github.com/containerd/console v1.0.3 github.com/containerd/containerd v1.7.2 github.com/cucumber/godog v0.0.0-00010101000000-000000000000 // replaced; see replace for the actual version used diff --git a/go.sum b/go.sum index 50317192daa..9e7c7f8eaf0 100644 --- a/go.sum +++ b/go.sum @@ -131,8 +131,8 @@ github.com/cncf/xds/go v0.0.0-20210922020428-25de7278fc84/go.mod h1:eXthEFrGJvWH github.com/cncf/xds/go v0.0.0-20211011173535-cb28da3451f1/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs= github.com/cncf/xds/go v0.0.0-20230607035331-e9ce68804cb4 h1:/inchEIKaYC1Akx+H+gqO04wryn5h75LSazbRlnya1k= github.com/codahale/rfc6979 v0.0.0-20141003034818-6a90f24967eb h1:EDmT6Q9Zs+SbUoc7Ik9EfrFqcylYqgPZ9ANSbTAntnE= -github.com/compose-spec/compose-go v1.15.1 h1:0yaEt6/66dLN0bNWYDTj0CDx626uCdQ9ipJVIJx8O8M= -github.com/compose-spec/compose-go v1.15.1/go.mod h1:3yngGBGfls6FHGQsg4B1z6gz8ej9SOvmAJtxCwgbcnc= +github.com/compose-spec/compose-go v1.16.0 h1:HYk4uYWXgArHh6NG+WE4yGYayOXw+hjqJ+eJxpjWWjk= +github.com/compose-spec/compose-go v1.16.0/go.mod h1:3yngGBGfls6FHGQsg4B1z6gz8ej9SOvmAJtxCwgbcnc= github.com/containerd/cgroups v1.1.0 h1:v8rEWFl6EoqHB+swVNjVoCJE8o3jX7e8nqBGPLaDFBM= github.com/containerd/console v1.0.3 h1:lIr7SlA5PxZyMV30bDW0MGbiOPXwc63yRuCP0ARubLw= github.com/containerd/console v1.0.3/go.mod h1:7LqA/THxQ86k76b8c/EMSiaJ3h1eZkMkXar0TQ1gf3U= diff --git a/pkg/utils/set.go b/pkg/utils/set.go index e39c81d6f7f..4688cb9efff 100644 --- a/pkg/utils/set.go +++ b/pkg/utils/set.go @@ -47,3 +47,9 @@ func (s Set[T]) Elements() []T { } return elements } + +func (s Set[T]) RemoveAll(elements ...T) { + for _, e := range elements { + s.Remove(e) + } +}