registry/client: remove uses of APIEndpoint.TrimHostName #5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5674 +/- ##
==========================================
- Coverage 59.54% 59.50% -0.04%
==========================================
Files 346 346
Lines 29376 29371 -5
==========================================
- Hits 17491 17478 -13
- Misses 10914 10923 +9
+ Partials 971 970 -1 |
thaJeztah
commented
Dec 9, 2024
thaJeztah
force-pushed
the
registry_trimname
branch
from
bd2f038 to
2033c28
Compare
This field was added in moby/moby@19515a7, but looks to be always set for endpoints used, so we can trim remote names unconditionally. This option was added for possible future expansion, allowing registry- mirrors to get the full reference of the image (including domain-name), for them to host a mirror for multiple upstreams on the same registry. That approach will unlikely be implemented, and containerd has a different approach for this, where the reference to the original registry is passed through a query parameter instead. Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: moby/moby@5d72419...b249c5e Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
registry_trimname
branch
from
2033c28 to
2a5ac8f
Compare
vvoland
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registry/client: remove uses of APIEndpoint.TrimHostName
This field was added in moby/moby@19515a7, but looks to be always set for endpoints used, so we can trim remote names unconditionally.
This option was added for possible future expansion, allowing registry- mirrors to get the full reference of the image (including domain-name), for them to host a mirror for multiple upstreams on the same registry.
That approach will unlikely be implemented, and containerd has a different approach for this, where the reference to the original registry is passed through a query parameter instead.
vendor: github.com/docker/docker b249c5ebd214 (master, v28.0.0-dev)
full diff: moby/moby@5d72419...b249c5e
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)