Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update various golang.org/x/ dependencies #5671

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

thaJeztah
Copy link
Member

vendor: golang.org/x/sys v0.27.0

full diff: golang/sys@v0.26.0...v0.27.0

vendor: golang.org/x/sync v0.9.0

no changes in vendored code

full diff: golang/sync@v0.8.0...v0.9.0

vendor: golang.org/x/text v0.20.0

no changes in vendored code

full diff: golang/text@v0.19.0...v0.20.0

vendor: golang.org/x/term v0.26.0

full diff: golang/term@v0.25.0...v0.26.0

vendor: golang.org/x/crypto v0.29.0

no changes in vendored code

full diff: golang/crypto@v0.28.0...v0.29.0

vendor: golang.org/x/net v0.31.0

full diff: golang/net@v0.30.0...v0.31.0

no changes in vendored code

full diff: golang/sync@v0.8.0...v0.9.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
no changes in vendored code

full diff: golang/text@v0.19.0...v0.20.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
no changes in vendored code

full diff: golang/crypto@v0.28.0...v0.29.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.50%. Comparing base (66dfe6d) to head (9399483).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5671   +/-   ##
=======================================
  Coverage   59.50%   59.50%           
=======================================
  Files         346      346           
  Lines       29367    29367           
=======================================
  Hits        17474    17474           
  Misses      10920    10920           
  Partials      973      973           

Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for always splitting the commits btw. I didn't appreciate this until I started maintaining and backporting. It's really changed how I author my commits. :)

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@laurazard laurazard merged commit be6ddae into docker:master Dec 9, 2024
101 checks passed
@thaJeztah thaJeztah deleted the bump_x_deps branch December 9, 2024 11:06
@thaJeztah
Copy link
Member Author

Thanks for always splitting the commits btw. I didn't appreciate this until I started maintaining and backporting. It's really changed how I author my commits. :)

Thanks! I should automate more of that, as it's still a bit manual (e.g. the diff-URL for vanity domains like the golang.org/x/ ones is a bit cumbersome).

I like having the diffs separate (where reasonably possible); it somewhat keeps each step "reviewable", and can sometimes be useful for backporting. Having the full diff (unfortunately GitHub doesn't provide links for subdirectories (sub modules)) can help review changes in dependencies, and it forces me a bit to have at least a peek at "what changed" to understand if there's any problematic areas or changes that I should be aware of (sometimes new functionality that we should start using).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants