pkg/command: pass context along to DisplayJSONMessagesStream
#5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benehiko
force-pushed
the
ctx-jsonmessage
branch
from
c9daf48 to
c21438f
Compare
…ream` Allows for the `jsonmessage.DisplayJSONMessagesStream` to correctly return when the context is cancelled with the appropriate error message, instead of just a nil error. Follow-up to docker@30a73ff Signed-off-by: Alano Terblanche <[email protected]>
Benehiko
force-pushed
the
ctx-jsonmessage
branch
from
c21438f to
4884112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5639
Requires: moby/moby#49016
Allows for the
jsonmessage.DisplayJSONMessagesStreamtocorrectly return when the context is cancelled with the
appropriate error message, instead of just a nil error.
Follow-up to 30a73ff
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)