Flaky test: TestVolumeCreateClusterOpts

[thaJeztah]

Looks like we have a new flaky test; I'm guessing something is using a map, and therefore randomized by Go. Introduced in #3606

--- FAIL: TestVolumeCreateClusterOpts (0.00s)
    create_test.go:195: assertion failed: 
        --- body
        +++ expectedBody
          volume.CreateOptions{
          	ClusterVolumeSpec: &volume.ClusterVolumeSpec{
          		... // 2 identical fields
          		AccessibilityRequirements: &{Requisite: {{Segments: {"region": "R1", "zone": "Z1"}}, {Segments: {"region": "R1", "zone": "Z2"}}, {Segments: {"region": "R1", "zone": "Z3"}}}, Preferred: {{Segments: {"region": "R1", "zone": "Z2"}}, {Segments: {"region": "R1", "zone": "Z3"}}}},
          		CapacityRange:             &{RequiredBytes: 1234, LimitBytes: 567890},
          		Secrets: []volume.Secret{
        - 			{Key: "key2", Secret: "secret2"},
          			{Key: "key1", Secret: "secret1"},
        + 			{Key: "key2", Secret: "secret2"},
          		},
          		Availability: "active",
          	},
          	Driver:     "csi",
          	DriverOpts: {},
          	... // 2 identical fields
          }

/cc @dperny

[photra]

I also encountered this flaky test when working on another PR. It looks like the snippet below is the root cause:

cli/cli/command/volume/create.go

Lines 127 to 135 in 3455580

	for key, secret := range options.secrets.GetAll() {
	volOpts.ClusterVolumeSpec.Secrets = append(
	volOpts.ClusterVolumeSpec.Secrets,
	volume.Secret{
	Key: key,
	Secret: secret,
	},
	)
	}

Like @thaJeztah suggested,options.secrets.GetAll() returns a map, which is then parsed into a slice, leading to randomized ordering of secrets. I will follow up with a PR to deflake TestVolumeCreateClusterOpts