Skip to content

Commit

Permalink
Merge pull request #5650 from laurazard/cleanup-tests-1
Browse files Browse the repository at this point in the history
 tests: cleanup table test names
  • Loading branch information
thaJeztah authored Nov 27, 2024
2 parents ba1a154 + 1d4a7ae commit bc908a6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cli/command/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func TestValidateOutputPath(t *testing.T) {
}

func TestPromptForInput(t *testing.T) {
t.Run("case=cancelling the context", func(t *testing.T) {
t.Run("cancelling the context", func(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
t.Cleanup(cancel)
reader, _ := io.Pipe()
Expand Down Expand Up @@ -116,7 +116,7 @@ func TestPromptForInput(t *testing.T) {
}
})

t.Run("case=user input should be properly trimmed", func(t *testing.T) {
t.Run("user input should be properly trimmed", func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
t.Cleanup(cancel)

Expand Down Expand Up @@ -196,7 +196,7 @@ func TestPromptForConfirmation(t *testing.T) {
return promptReader.Close()
}, promptResult{false, nil}},
} {
t.Run("case="+tc.desc, func(t *testing.T) {
t.Run(tc.desc, func(t *testing.T) {
notifyCtx, notifyCancel := signal.NotifyContext(ctx, syscall.SIGINT, syscall.SIGTERM)
t.Cleanup(notifyCancel)

Expand Down
2 changes: 1 addition & 1 deletion e2e/global/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func TestPromptExitCode(t *testing.T) {
}

for _, tc := range testCases {
t.Run("case="+tc.name, func(t *testing.T) {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()

buf := new(bytes.Buffer)
Expand Down

0 comments on commit bc908a6

Please sign in to comment.