From 24fb803f9e45362adcd07431bf04a6e58ebc1aa9 Mon Sep 17 00:00:00 2001 From: Matthew MacLeod Date: Thu, 28 Nov 2024 15:21:23 +0000 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Simplify test assertion Co-authored-by: Paweł Gronowski Signed-off-by: Matthew MacLeod --- cli/connhelper/connhelper_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cli/connhelper/connhelper_test.go b/cli/connhelper/connhelper_test.go index a5de3db5ac36..16aa78e2ebae 100644 --- a/cli/connhelper/connhelper_test.go +++ b/cli/connhelper/connhelper_test.go @@ -86,9 +86,7 @@ func TestDockerSSHBinaryOverride(t *testing.T) { t.Run(tc.name, func(t *testing.T) { t.Setenv(DockerSSHRemoteBinaryEnv, tc.env) result := dockerSSHRemoteBinary() - if result != tc.expected { - t.Errorf("expected %q, got %q", tc.expected, result) - } + assert.Check(t, is.Equal(result, tc.expected)) }) } }