Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support build.secrets in yaml #1060

Closed
ciaranmcnulty opened this issue Apr 11, 2022 · 0 comments · Fixed by #1069
Closed

Support build.secrets in yaml #1060

ciaranmcnulty opened this issue Apr 11, 2022 · 0 comments · Fixed by #1069
Labels
area/bake/compose area/bake kind/enhancement New feature or request

Comments

@ciaranmcnulty
Copy link

ciaranmcnulty commented Apr 11, 2022 •
edited
Loading

Compose has added a <service>.build.secrets key and ...ssh is on the way

compose-spec/compose-spec#238

It looks to me to be broadly similar to build.x-bake.secrets so hopefully can be supported simply, the only issue might be merging?

I would suggest that if both are present they're merged, de-duplicating by id, but it might be simpler to have a hard error when both are used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/bake/compose area/bake kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bake: support compose build secrets crazy-max/buildx
2 participants
@ciaranmcnulty @crazy-max