-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't add WP_DEBUG=TRUE if WORDPRESS_DEBUG is set to FALSE #496
Comments
For simplicity of our bash scripts across many official-images, we don't look for "truthy" values and instead just use the fact of it being filled/set to turn it on and unset/empty to turn if off. |
@yosifkit Thanks for a quick response. Though it is okay for those who spin the container directly. But doesn't fit with Docker-compose or .env file. |
I think this is the crux of the disagreement here -- our Frankly, I'd love to deprecate it entirely in favor of the newer and much more flexible WORDPRESS_CONFIG_EXTRA: |
define('WP_DEBUG', boolval(getenv('WP_DEBUG'))); |
@tianon I agree with your point completely. Thanks |
Hi, I agree that setting this value with any value should enable WP_DEBUG according the documentation. However unsetting this variable will not turn off debugging again. The following change would allow us to turn off debugging.
|
I have a .env.example inside my docker-compose project. For simplicity, when onboarding a team member, I just ask to rename it to .env, change the debug value if you are developer, and
docker-compose up
.If you are a designer you don't need to change that value. Just keep its value as it is. i.e By default I have the env variable set to FALSE. But even if it is set to false it adds
WP_DEBUG=true
.So please don't check with an empty variable. Rather it should be checked if it is set to true or not
wordpress/docker-entrypoint.sh
Line 231 in 8215003
The text was updated successfully, but these errors were encountered: