Reorder python import test to use gnu dbm imports instead of generic dbm #2284

yosifkit · 2016-10-25T22:21:31Z

Re: docker-library/buildpack-deps#49, docker-library/python#151

tianon · 2016-10-25T22:39:40Z

Build test of #2284; 9358b83 (python:2.7.12, python:2.7.12-alpine, python:2.7.12-slim, python:3.5.2, python:3.5.2-alpine, python:3.5.2-slim, pypy:2-5.4.1, pypy:2-5.4.1-slim, pypy:3-5.5.0-alpha, pypy:3-5.5.0-alpha-slim):

$ bashbrew build python:2.7.12
Using bashbrew/cache:6025bab1dde01b8f4b58257ce3f4b3cbdc247021c7da35e6101829c137f28f40 (python:2.7.12)
Tagging python:2.7.12
Tagging python:2.7
Tagging python:2

$ test/run.sh python:2.7.12
testing python:2.7.12
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 13, in <module>
    import gdbm
ImportError: No module named gdbm
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build python:2.7.12-alpine
Using bashbrew/cache:a0e30e74ffbcefd92e545b418be6f4d00b730911e36d533e04a0f787163e16bb (python:2.7.12-alpine)
Tagging python:2.7.12-alpine
Tagging python:2.7-alpine
Tagging python:2-alpine

$ test/run.sh python:2.7.12-alpine
testing python:2.7.12-alpine
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...passed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build python:2.7.12-slim
Building bashbrew/cache:ec4604227b9fa64177bc3f2f0781737253f7f4df801320f5375a9ec8e6bf35d0 (python:2.7.12-slim)
Tagging python:2.7.12-slim
Tagging python:2.7-slim
Tagging python:2-slim

$ test/run.sh python:2.7.12-slim
testing python:2.7.12-slim
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 13, in <module>
    import gdbm
ImportError: No module named gdbm
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build python:3.5.2
Using bashbrew/cache:29704ccbdf3b5a2997ed6dc30a29d5727b1624c76534c7d0a5a7cbb3c9907c7e (python:3.5.2)
Tagging python:3.5.2
Tagging python:3.5
Tagging python:3
Tagging python:latest

$ test/run.sh python:3.5.2
testing python:3.5.2
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 15, in <module>
    import dbm.gnu
  File "/usr/local/lib/python3.5/dbm/gnu.py", line 3, in <module>
    from _gdbm import *
ImportError: No module named '_gdbm'
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build python:3.5.2-alpine
Building bashbrew/cache:f73d6b5bc3fe0b883132aa7752da07de72974d7f744acd3fd6807497f4f23ab3 (python:3.5.2-alpine)
Tagging python:3.5.2-alpine
Tagging python:3.5-alpine
Tagging python:3-alpine
Tagging python:alpine

$ test/run.sh python:3.5.2-alpine
testing python:3.5.2-alpine
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 15, in <module>
    import dbm.gnu
  File "/usr/local/lib/python3.5/dbm/gnu.py", line 3, in <module>
    from _gdbm import *
ImportError: No module named '_gdbm'
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build python:3.5.2-slim
Building bashbrew/cache:d9e2721b331ad84865f70bf50a80906ed995f8c9222e44274ac01128b7c675c8 (python:3.5.2-slim)
Tagging python:3.5.2-slim
Tagging python:3.5-slim
Tagging python:3-slim
Tagging python:slim

$ test/run.sh python:3.5.2-slim
testing python:3.5.2-slim
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 15, in <module>
    import dbm.gnu
  File "/usr/local/lib/python3.5/dbm/gnu.py", line 3, in <module>
    from _gdbm import *
ImportError: No module named '_gdbm'
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build pypy:2-5.4.1
Using bashbrew/cache:a36c29b49c414c56a23545fde4be248256644aaed5201a7ab802de46a3241e04 (pypy:2-5.4.1)
Tagging pypy:2-5.4.1
Tagging pypy:2-5.4
Tagging pypy:2-5
Tagging pypy:2

$ test/run.sh pypy:2-5.4.1
testing pypy:2-5.4.1
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...passed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build pypy:2-5.4.1-slim
Building bashbrew/cache:465c3e8d9012d6c18d86df89561123c99686d9f6999700dd1fc30c60cb7fcc69 (pypy:2-5.4.1-slim)
Tagging pypy:2-5.4.1-slim
Tagging pypy:2-5.4-slim
Tagging pypy:2-5-slim
Tagging pypy:2-slim

$ test/run.sh pypy:2-5.4.1-slim
testing pypy:2-5.4.1-slim
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]..../container.sh: 5: ./container.sh: python: not found
skipping Hy test -- no workie on Python 3.6+
passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 13, in <module>
    import gdbm
  File "/usr/local/lib_pypy/gdbm.py", line 1, in <module>
    from _gdbm_cffi import ffi, lib    # generated by _gdbm_build.py
ImportError: unable to load extension module '/usr/local/lib_pypy/_gdbm_cffi.pypy-41.so': libgdbm.so.3: cannot open shared object file: No such file or directory
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build pypy:3-5.5.0-alpha
Using bashbrew/cache:5e5bccdaa82b96bd94d614a451cedb941e5182be881554b5afcdfe1bad4753bb (pypy:3-5.5.0-alpha)
Tagging pypy:3-5.5.0-alpha
Tagging pypy:3-5.5.0
Tagging pypy:3-5.5
Tagging pypy:3-5
Tagging pypy:3
Tagging pypy:latest

$ test/run.sh pypy:3-5.5.0-alpha
testing pypy:3-5.5.0-alpha
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...passed
    'python-imports' [6/8]...passed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

$ bashbrew build pypy:3-5.5.0-alpha-slim
Building bashbrew/cache:d5c1d312e7ca625dd27c7ad252b4cfdd39ef91245c2de4608744e8872fb9be7c (pypy:3-5.5.0-alpha-slim)
Tagging pypy:3-5.5.0-alpha-slim
Tagging pypy:3-5.5.0-slim
Tagging pypy:3-5.5-slim
Tagging pypy:3-5-slim
Tagging pypy:3-slim
Tagging pypy:slim

$ test/run.sh pypy:3-5.5.0-alpha-slim
testing pypy:3-5.5.0-alpha-slim
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]..../container.sh: 5: ./container.sh: python: not found
skipping Hy test -- no workie on Python 3.6+
passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 15, in <module>
    import dbm.gnu
  File "/usr/local/lib-python/3/dbm/gnu.py", line 3, in <module>
    from _gdbm import *
  File "/usr/local/lib_pypy/_gdbm.py", line 1, in <module>
    from _gdbm_cffi import ffi, lib    # generated by _gdbm_build.py
ImportError: libgdbm.so.3: cannot open shared object file: No such file or directory
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

The following images failed at least one test: python:2.7.12 python:2.7.12-slim python:3.5.2 python:3.5.2-alpine python:3.5.2-slim pypy:2-5.4.1-slim pypy:3-5.5.0-alpha-slim

yosifkit · 2016-10-25T22:49:22Z

Looks like we have some pypy fixes to do, but I have a PR for python slim and alpine ready to submit once these tests are merged.

tianon

Test failures are indeed expected (and the whole point -- now we know where to fix things) 👍

Reorder python import test to use gnu dbm imports instead of generic dbm

9358b83

yosifkit mentioned this pull request Oct 25, 2016

Add libgdbm-dev for python and ruby (libgdbm3 is already pulled in by perl) docker-library/buildpack-deps#49

Merged

3 tasks

tianon approved these changes Oct 25, 2016

View reviewed changes

tianon merged commit 72efe15 into docker-library:master Oct 25, 2016

tianon deleted the python-gbdm branch October 25, 2016 22:53

yosifkit mentioned this pull request Oct 25, 2016

Add gdbm-dev to slim and alpine images docker-library/python#153

Merged

tianon mentioned this pull request Nov 4, 2016

Upgraded to pip 9.0.1 docker-library/python#154

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorder python import test to use gnu dbm imports instead of generic dbm #2284

Reorder python import test to use gnu dbm imports instead of generic dbm #2284

yosifkit commented Oct 25, 2016

tianon commented Oct 25, 2016

yosifkit commented Oct 25, 2016

tianon left a comment

Reorder python import test to use gnu dbm imports instead of generic dbm #2284

Reorder python import test to use gnu dbm imports instead of generic dbm #2284

Conversation

yosifkit commented Oct 25, 2016

tianon commented Oct 25, 2016

yosifkit commented Oct 25, 2016

tianon left a comment

Choose a reason for hiding this comment