Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Registry to v2.2.0 #1160

Merged
merged 1 commit into from
Nov 3, 2015

Conversation

RichardScothern
Copy link
Contributor

Signed-off-by: Richard Scothern [email protected]

@yosifkit
Copy link
Member

yosifkit commented Nov 3, 2015

Don't you need a 2.2 tag also? Also, you can drop 2.1* tags if they are not going to get new releases. This will drop them from the "supported tags" section on the hub and they will not be rebuilt, but they will still be available to pull from the Docker Hub.

Changeset: distribution/distribution-library-image@d5f65e0...af287a2

Build test of #1160; 7b13ec0 (registry):

$ url="https://raw.githubusercontent.com/docker-library/official-images/7b13ec0d173986f1d51f55e546e36b9f16cac5cf/library/registry"
$ bashbrew build "$url"
Fetching registry (git://github.com/docker/distribution-library-image) ...
Processing registry:latest ...
Processing registry:0.8.1 ...
Processing registry:0.9.1 ...
Processing registry:2 ...
Processing registry:2.1 ...
Processing registry:2.1.1 ...
Processing registry:2.2.0 ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing registry:latest
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing registry:0.8.1
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing registry:2
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...configuration error: open echo: no such file or directory

Usage: 
  registry <config> [flags]
Flags:
  -h, --help=false: help for registry
  -v, --version=false: show the version and exit

failed
testing registry:2.1
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...configuration error: open echo: no such file or directory
usage: /bin/registry <config>
  -test.bench="": regular expression to select benchmarks to run
  -test.benchmem=false: print memory allocations for benchmarks
  -test.benchtime=1s: approximate run time for each benchmark
  -test.blockprofile="": write a goroutine blocking profile to the named file after execution
  -test.blockprofilerate=1: if >= 0, calls runtime.SetBlockProfileRate()
  -test.coverprofile="": write a coverage profile to the named file after execution
  -test.cpu="": comma-separated list of number of CPUs to use for each test
  -test.cpuprofile="": write a cpu profile to the named file during execution
  -test.memprofile="": write a memory profile to the named file after execution
  -test.memprofilerate=0: if >=0, sets runtime.MemProfileRate
  -test.outputdir="": directory in which to write profiles
  -test.parallel=1: maximum test parallelism
  -test.run="": regular expression to select tests and examples to run
  -test.short=false: run smaller test suite to save time
  -test.timeout=0: if positive, sets an aggregate time limit for all tests
  -test.v=false: verbose: print additional output
  -version=false: show the version and exit
failed

There is at least one failure in the above build log.

(the override-cmd test failure is expected on registry:2.* until latest changes)

Add '2.2.0' and '2.2' tags.  Update '2' tag to point to 2.2.

Remove 2.1 and 2.1.1 as they will not get newer releases, but will still be
available from the hub.

Signed-off-by: Richard Scothern <[email protected]>
@RichardScothern
Copy link
Contributor Author

Thanks @yosifkit ; you were right on all counts.

@yosifkit
Copy link
Member

yosifkit commented Nov 3, 2015

LGTM, Build test of #1160; 4a3b555 (registry):

$ url="https://raw.githubusercontent.com/docker-library/official-images/4a3b5555507d2df0a4dd8f95977cf333be1a0aa9/library/registry"
$ bashbrew build "$url"
Processing registry:latest ...
Processing registry:0.8.1 ...
Processing registry:0.9.1 ...
Processing registry:2 ...
Processing registry:2.2 ...
Processing registry:2.2.0 ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing registry:latest
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing registry:0.8.1
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing registry:2
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...configuration error: open echo: no such file or directory

Usage: 
  registry <config> [flags]
Flags:
  -h, --help=false: help for registry
  -v, --version=false: show the version and exit

failed

There is at least one failure in the above build log.

yosifkit added a commit that referenced this pull request Nov 3, 2015
@yosifkit yosifkit merged commit 0d0d1f9 into docker-library:master Nov 3, 2015
@RichardScothern RichardScothern deleted the registry-v2.2.0 branch November 11, 2016 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants