Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include SSH client for SSH protocol in DOCKER_HOST #206

Closed
a-abella opened this issue Dec 7, 2019 · 1 comment · Fixed by #207
Closed

Include SSH client for SSH protocol in DOCKER_HOST #206

a-abella opened this issue Dec 7, 2019 · 1 comment · Fixed by #207
Labels
Request Request for image modification or feature

Comments

@a-abella
Copy link

a-abella commented Dec 7, 2019

Docker 18.09 added SSH as a supported protocol for the Docker client DOCKER_HOST configuration. This configuration requires an SSH client to be installed. I noticed that the docker-git images include SSH, but the base images do not. As DOCKER_HOST over SSH is now built-in Docker functionality, it may be correct to include SSH with the base image in order to preserve that functionality.
@a-abella a-abella changed the title Support for ssh protocol in DOCKER_HOST Include SSH client for SSH protocol in DOCKER_HOST Dec 7, 2019
@wglambert wglambert added the Request Request for image modification or feature label Dec 10, 2019
@tianon tianon mentioned this issue Dec 10, 2019
Merged
@tianon
Copy link
Member

tianon commented Dec 10, 2019

Good catch; I tested and it adds ~6MB, which is totally reasonable, thus #207 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Request Request for image modification or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "openssh-client" to the standard client images infosiftr/docker
3 participants
@tianon @a-abella @wglambert