Bump version to 19.03.6.rc2 #640
Conversation
|
There's a buildkit commit just merged in moby/moby's 19.03 brach. Did you want to pick that up for rc2? |
|
sure @cpuguy83 |
|
are we good to go @tiborvass @thaJeztah @tonistiigi @cpuguy83 @AkihiroSuda |
There was a problem hiding this comment.
Changelog needs update https://github.com/docker/docker-ce/blob/19.03/CHANGELOG.md#runtime
|
good catch @tiborvass, edited the |
|
You missed moby/moby#40440 (fixes moby/moby#40335) in the Changelog. Something like: |
| * Update to runc v1.0.0-rc9. [docker/engine#428](https://github.com/docker/engine/pull/428) | ||
| * Bump Golang 1.12.16. [moby/moby#40433](https://github.com/moby/moby/pull/40433) | ||
| * Update containerd binary to v1.2.12. [moby/moby#40433](https://github.com/moby/moby/pull/40453) | ||
| * Update to runc v1.0.0-rc10. [moby/moby#40433](https://github.com/moby/moby/pull/40453) | ||
| - Fix possible runtime panic in Lgetxattr. [docker/engine#454](https://github.com/docker/engine/pull/454) |
There was a problem hiding this comment.
Should we mention the CVE's that were fixed both in Golang and Runc/containerd ?
There was a problem hiding this comment.
From a quick scan of the CHANGELOG, I don't think we've specified Golang CVE's in the past, the links should have the CVE details in there
CHANGELOG.md
Outdated
|
|
||
| ### Builder | ||
|
|
||
| - builder-next: Allow modern sign hashes for ssh forwarding. [docker/engine#453](https://github.com/docker/engine/pull/453) | ||
| - builder-next: Clear onbuild rules after triggering. [docker/engine#453](https://github.com/docker/engine/pull/453) | ||
| - bump hcsshim to fix docker build failing on Windows 1903. [docker/engine#429](https://github.com/docker/engine/pull/429) | ||
| - Bump hcsshim to fix docker build failing on Windows 1903. [docker/engine#429](https://github.com/docker/engine/pull/429) | ||
| - Fix issue with directory permissions when BuildKit and usernamespaces are enabled. [moby/moby#40440](https://github.com/moby/moby/pull/40440) |
There was a problem hiding this comment.
@arkodg sorry didn't see the builder-next: prefix. This one should have it as well, and we can thus s/BuildKit and // and s/are enabled/is enabled/
Signed-off-by: Arko Dasgupta <[email protected]>
|
Can we have the tag on Moby repo? |
|
@AkihiroSuda Yeah we discussed this on slack and seems like we want to go ahead move all the tags in docker/engine. |
…ings rpmlint: fix "E: description-line-too-long"
No description provided.