Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Add ssl/tls support in discovery backends #404

Closed
david-guenault opened this issue Feb 18, 2015 · 7 comments
Closed

Add ssl/tls support in discovery backends #404

david-guenault opened this issue Feb 18, 2015 · 7 comments

Comments

@david-guenault
Copy link

Since all the docker tools support SSL/TLS (docker, swarm, compose ...) should it be possible in the future to add the same for discovery backends. For exemple etcd and consul does support ssl/tls but it is not possible to enable it in swarm discovery backends.

As a reference you can see #360

@vieux
Copy link
Contributor

vieux commented Feb 18, 2015

I agree

@david-guenault
Copy link
Author

@vieux, thinking about that i do not see how it should be implemented. The only parameter that it is curently possible is the discovery uri in the form [backend]://ip:port, ip:port,.../path. How should it be implemented ? With environment variables ?

@vieux
Copy link
Contributor

vieux commented Feb 28, 2015

@david-guenault what about etcds:// and consuls:// ? and we use the same tls certs we already have

@thaJeztah
Copy link
Member

or something like etcd+https://, consul+https://?

@bacongobbler
Copy link
Contributor

I'm 👍 for etcds://. I could see etcd+https:// being interpreted by users as being two separate connections (etcd and https) rather than a single connection through a tls-secured etcd backend. https:// also sets a precedent here as being "HTTP over TLS", so it makes sense in my mind that etcds:// implies "etcd over TLS".

Plus, it's less typing :)

@david-guenault
Copy link
Author

sorry i've been out for a while. Well etcds seems fine for me.

@abronan
Copy link
Contributor

abronan commented Oct 13, 2015

Fixed by #1254. Swarm now supports TLS for consul and etcd through libkv and the --discovery-opt flag. Closing this one.

@abronan abronan closed this as completed Oct 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants