Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Version Tag to Footer #612

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Sep 8, 2023

This currently uses an environment variable (VITE_DOCAT_VERSION) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427

@reglim reglim force-pushed the feature/427-add-version-tag branch 7 times, most recently from 6c5b6ec to 35609ec Compare September 12, 2023 12:25
@reglim reglim marked this pull request as ready for review September 12, 2023 12:40
@reglim reglim force-pushed the feature/427-add-version-tag branch 3 times, most recently from e6e98ed to e9bdfea Compare October 3, 2023 06:14
Copy link
Member

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reglim reglim force-pushed the feature/427-add-version-tag branch from e9bdfea to e4662ba Compare October 3, 2023 08:39
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the last tag + the number of commits since + the current hash (if dirty) in the Footer.

Also added the Footer to the Help page.

Fixes: #427
@reglim reglim force-pushed the feature/427-add-version-tag branch from e4662ba to 19c3a2f Compare October 3, 2023 08:45
@reglim reglim merged commit 98a1b6a into main Oct 3, 2023
8 checks passed
@reglim reglim deleted the feature/427-add-version-tag branch October 3, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Version Tag to Footer
2 participants