Fix/docs-page-url-handling #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
force-pushed
the
fix/render-loop
branch
2 times, most recently
from
04cdd19
to
bf6e629
Compare
I rebuilt the entire Docs page, and seperated the iframe into a seperate component that interacts with the Docs page via callbacks.
…anged back to latest
reglim
force-pushed
the
fix/render-loop
branch
from
bf6e629
to
d68d806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebuilt the entire Docs page, and seperated the iframe into a seperate component that interacts with the Docs page via callbacks.
I also added a function to the message provider so we can hide the outdated version warning when the version is changed back to the latest version.
Finally I changed the
escapeSlashcomponent to replace instead of push the url.Seems to work pretty well in my testing, please report any issues.