Fix: Links to Docs page didn't work #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
from
8d8a0fe
to
b494493
Compare
This comment was marked as outdated.
This comment was marked as outdated.
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
4 times, most recently
from
792fa91
to
8de8bff
Compare
reglim
changed the title
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
4 times, most recently
from
94d7032
to
7229b5e
Compare
randombenj
reviewed
Mar 27, 2023
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
8 times, most recently
from
791abea
to
58b45e6
Compare
|
i had a quick look no idea what that does but seems fine to me if it works |
Here's an explanation: https://stackoverflow.com/a/17800131/20919151 |
This is something I usually try to add as a source code comment so it is more clear when reading the code ;) |
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
from
58b45e6
to
0bd5220
Compare
Fair, I just thought it's such a common pattern in nginx configs that I didn't bother ... |
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
3 times, most recently
from
f21ebbf
to
5fa4bb3
Compare
fliiiix
reviewed
Mar 29, 2023
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
from
5fa4bb3
to
5a58007
Compare
I fixed it by just making sure we insert a # between the host and the location part in the url in the Home Component (that is where 404 requests ultimately land, if they don't have a # in the url). fixes: #477
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
2 times, most recently
from
14428ab
to
d83ff65
Compare
reglim
changed the title
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
3 times, most recently
from
e9bdb56
to
7702f73
Compare
randombenj
approved these changes
Apr 11, 2023
It now shows "v. {version}" with a space and always gets the correct
latest version that you would land on if you click on the link.
fixes: #479
reglim
force-pushed
the
fix/links-to-docs-page-not-working
branch
from
7702f73
to
f41e8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs page was way too complicated anyway, so I simplified it a bit.
I fixed the following issues:
fixes: #475, #476, #477, #479