Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version Tag to Footer #427

Closed
reglim opened this issue Feb 21, 2023 · 5 comments · Fixed by #612
Closed

Add Version Tag to Footer #427

reglim opened this issue Feb 21, 2023 · 5 comments · Fixed by #612

Comments

@reglim
Copy link
Contributor

reglim commented Feb 21, 2023

It would be useful for auto-deployed systems if the current release / the current docker hash would be displayed in the footer or somewhere else so one can easily verify whether a new version has been published already.

@larrycai
Copy link

for end user, important thing is to know

  • what docat version is used now (show in portal/help page)
  • each release has a version which matches docker image tag, hash is good, but not so easy to check for end-user

@reglim
Copy link
Contributor Author

reglim commented Apr 14, 2023

I think just using the docker image tag should theoretically work, since you're usually running docat with a version like 0.3.0, and if not, the hash would be fine, since you're probably running it for test purposes.

@fliiiix
Copy link
Member

fliiiix commented Sep 8, 2023

We could/should show it at least on the /#/help page

reglim added a commit that referenced this issue Sep 8, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Sep 8, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
@reglim
Copy link
Contributor Author

reglim commented Sep 8, 2023

Currently implemented as follows:

There is a tag on our current commit, we use that:

image

If not, we use the commit hash which should be easy for devs to verify :

image

reglim added a commit that referenced this issue Sep 8, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Sep 8, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Sep 8, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Sep 12, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Sep 12, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Sep 12, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Sep 12, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
@reglim
Copy link
Contributor Author

reglim commented Sep 12, 2023

That didn't work on the github pipeline (where it seems like the commit hash is used as a tag), so I just resorted to using the tag if present and the short hash if not.

reglim added a commit that referenced this issue Oct 3, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Oct 3, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the commit hash (if dirty) in the Footer.

Fixes: #427
reglim added a commit that referenced this issue Oct 3, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the last tag + the number of commits since + the current hash (if dirty) in the Footer.

Also added the Footer to the Help page.

Fixes: #427
reglim added a commit that referenced this issue Oct 3, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the last tag + the number of commits since + the current hash (if dirty) in the Footer.

Also added the Footer to the Help page.

Fixes: #427
reglim added a commit that referenced this issue Oct 3, 2023
This currently uses an environment variable (`VITE_DOCAT_VERSION`) to display either the tag (if clean) or the last tag + the number of commits since + the current hash (if dirty) in the Footer.

Also added the Footer to the Help page.

Fixes: #427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants