-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent uninstalling DDR Module #3942
Comments
This one is quite interesting reallybnas there are times and places that it can be removed. We only have a “system” flag. And I guess this would meet that standard. @david-poindexter thoughts? |
The reason behind the suggestion is that somebody did it an posted on the DNN Community Forums. Besides when your skin doesn't use DDR, what are the "other times and places"? |
I think marking it as system would be fine, it's not clear right now that it's in use as it's a module and a SKO |
There are cases when it is not used at all and can be uninstalled. I could understand the argument of making it uninstallable though. It is like anything else that provides functionality in other contexts. A super user should know what they are doing when they uninstall something like this. So we want the platform to be more "dummy proof", we could go this route. 😉 |
Well as we mark some skins as System and as I guess 90% of the skins (the DNN GO skins excluded) are using DDR menu, I think marking it as system is good.Especially because it looks like a module that's not in use unless you know it's also a skin object. |
Excellent points @Timo-Breumelhof |
Description of problem
The DDR Module can be uninstalled from the Extensions page. If that is done, the DDN skin object won't work.
Description of solution
Mark the DDR Module as one that cannot be uninstalled
Description of alternatives considered
none
The text was updated successfully, but these errors were encountered: