Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent uninstalling DDR Module #3942

Closed
jncraig opened this issue Jul 28, 2020 · 6 comments · Fixed by #4180
Closed

Prevent uninstalling DDR Module #3942

jncraig opened this issue Jul 28, 2020 · 6 comments · Fixed by #4180

Comments

@jncraig
Copy link

jncraig commented Jul 28, 2020

Description of problem

The DDR Module can be uninstalled from the Extensions page. If that is done, the DDN skin object won't work.

Description of solution

Mark the DDR Module as one that cannot be uninstalled

Description of alternatives considered

none

@mitchelsellers
Copy link
Contributor

This one is quite interesting reallybnas there are times and places that it can be removed.

We only have a “system” flag. And I guess this would meet that standard.

@david-poindexter thoughts?

@jncraig
Copy link
Author

jncraig commented Jul 28, 2020

The reason behind the suggestion is that somebody did it an posted on the DNN Community Forums.

Besides when your skin doesn't use DDR, what are the "other times and places"?

@Timo-Breumelhof
Copy link
Contributor

I think marking it as system would be fine, it's not clear right now that it's in use as it's a module and a SKO

@valadas valadas changed the title Uninstall DDR Module Prevent uninstalling DDR Module Jul 29, 2020
@david-poindexter
Copy link
Contributor

There are cases when it is not used at all and can be uninstalled. I could understand the argument of making it uninstallable though. It is like anything else that provides functionality in other contexts. A super user should know what they are doing when they uninstall something like this. So we want the platform to be more "dummy proof", we could go this route. 😉

@Timo-Breumelhof
Copy link
Contributor

Well as we mark some skins as System and as I guess 90% of the skins (the DNN GO skins excluded) are using DDR menu, I think marking it as system is good.Especially because it looks like a module that's not in use unless you know it's also a skin object.
And I wonder how many users really know that..

@david-poindexter
Copy link
Contributor

Excellent points @Timo-Breumelhof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants