Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Forms): show a label along the indicator for async field processes #4410

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

tujoworker
Copy link
Member

This PR is based on #4409

Add showLabel to the FieldBlock, so that async processes have label instead of just the dots:

Screenshot 2024-12-17 at 10 35 02

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:40pm

Copy link

codesandbox-ci bot commented Dec 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

tujoworker and others added 2 commits December 17, 2024 21:22
Add `showLabel` to the FieldBlock, so that async processes have label instead of just the dots:

<img width="420" alt="Screenshot 2024-12-17 at 10 35 02" src="https://github.com/user-attachments/assets/df772014-aa63-4959-b7f1-b936eb0eb0b1" />
@tujoworker tujoworker force-pushed the feat/forms-submit-indocator-field-block-label branch from c65bfa5 to d4fbe89 Compare December 17, 2024 20:22
@langz langz merged commit 885ae0d into main Dec 17, 2024
9 of 10 checks passed
@langz langz deleted the feat/forms-submit-indocator-field-block-label branch December 17, 2024 20:51
tujoworker pushed a commit that referenced this pull request Dec 20, 2024
## [10.62.0](v10.61.0...v10.62.0) (2024-12-20)

### 🔁 CI

* upgrade playwright ([#4413](#4413)) ([27f2106](27f2106))

### ✨ Features

* **Forms:** add `label` and `showLabel` prop to Form.SubmitIndicator ([#4409](#4409)) ([95af6e3](95af6e3))
* **Forms:** add `update` method to `Form.setData` ([#4416](#4416)) ([d2f5c23](d2f5c23))
* **Forms:** show a label along the indicator for async field processes ([#4410](#4410)) ([885ae0d](885ae0d)), closes [#4409](#4409)

### 🐛 Bug Fixes

* **Autocomplete:** support query with unicodes when using `search_numbers` ([#4419](#4419)) ([f19b7da](f19b7da))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.62.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants