Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): throw error when date is invalid #4396

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 12, 2024

fixes #4372

As of right now, when clicking in the input field, it opens the calendar at the original date(2022-01-01):
Screenshot 2024-12-12 at 22 43 37

I assume the calendar needs to display the new/updated date(2024-12-12) instead?
Not entirely sure how to do so 🤔

Here's:

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 11:37am

@langz langz changed the title add example fix(DatePicker): throw error when date is invalid Dec 12, 2024
@langz langz changed the title fix(DatePicker): throw error when date is invalid fix(DatePicker): throw error when date is invalid Dec 12, 2024
Copy link

codesandbox-ci bot commented Dec 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz marked this pull request as ready for review December 12, 2024 21:34
@langz langz requested review from tujoworker and kimroen December 12, 2024 21:43
@langz langz merged commit f977ebc into main Dec 13, 2024
10 checks passed
@langz langz deleted the fix/datepicker-throws-error-when-date-is-invalid branch December 13, 2024 15:00
tujoworker pushed a commit that referenced this pull request Dec 13, 2024
## [10.61.0](v10.60.1...v10.61.0) (2024-12-13)

### 📝 Documentation

* add guidelines for writing commit messages to the contribution guide ([#4389](#4389)) ([34eff0e](34eff0e))
* **Upload:** add `id` property ([#4401](#4401)) ([56d4956](56d4956))

### ✨ Features

* **Forms:** add missing support for `defaultValue` for Field.Slider ([#4394](#4394)) ([701ab66](701ab66))
* **Logo:** update sbanken logo ([#4379](#4379)) ([069ae1a](069ae1a))
* **Upload:** make `id` property as optional ([#4405](#4405)) ([0c58973](0c58973))
* **Value.Upload:** add async `onFileClick` event ([#4397](#4397)) ([be1c21c](be1c21c))

### 🐛 Bug Fixes

* **DatePicker:** add `null` as possible date type as return value ([#4407](#4407)) ([363e0b5](363e0b5))
* **DatePicker:** throw error when `date` is invalid ([#4396](#4396)) ([f977ebc](f977ebc))
* **FieldBlock:** remove max-width for label when width stretch ([#4406](#4406)) ([20c02d4](20c02d4))
* **Forms:** enhance transformIn and transformOut to support changed array and object instances ([#4392](#4392)) ([ae4648a](ae4648a)), closes [#4366](#4366)
* **Slider:** ensure `min` and `max` value is respected when `step` doesn't fit exactly ([#4395](#4395)) ([2c00b0c](2c00b0c))
* **Tabs:** ensure cached content never takes up visual space ([#4399](#4399)) ([360aacc](360aacc))
* **Upload:** display files without anchor when their size is not given ([#4390](#4390)) ([70df7c8](70df7c8))
* **Upload:** display spinner in async `onFileClick` without file `id` ([#4393](#4393)) ([b743d6e](b743d6e))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kimroen
Copy link
Contributor

kimroen commented Dec 17, 2024

Thanks for fixing!

I assume the calendar needs to display the new/updated date(2024-12-12) instead?

Yeah I'd hope so, but not sure either 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

DatePicker throws error on 10.56.1 when date is invalid
3 participants