fix(FormLabel): unhandled runtime error, elem is null #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
approved these changes
Dec 2, 2024
tujoworker
pushed a commit
that referenced
this pull request
Dec 2, 2024
## [10.59.0](v10.58.0...v10.59.0) (2024-12-02) ### ✨ Features * **Upload:** disabling delete button when loading ([cca3388](cca3388)) ### 🐛 Bug Fixes * **FormLabel:** unhandled runtime error, elem is null ([#4354](#4354)) ([a3414f1](a3414f1)), closes [/github.com//pull/4354/files#diff-f476207b8a837f2c0dea83ca374c5d383bcd895b0f6f10e033e12d7c0a7a3f84R142](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/4354/files/issues/diff-f476207b8a837f2c0dea83ca374c5d383bcd895b0f6f10e033e12d7c0a7a3f84R142) * **Upload:** disabling delete button when loading ([#4348](#4348)) ([85445b4](85445b4))
|
🎉 This PR is included in version 10.59.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to add the and statement: https://github.com/dnbexperience/eufemia/pull/4354/files#diff-f476207b8a837f2c0dea83ca374c5d383bcd895b0f6f10e033e12d7c0a7a3f84R142
As all following code in the if statement is dependent on that
ref.currentis existing.Fixes #4352