Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Card): add style for nested cards #4244

Merged
merged 3 commits into from
Nov 8, 2024
Merged

feat(Card): add style for nested cards #4244

merged 3 commits into from
Nov 8, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Nov 7, 2024

The same style as we have in the Edit- and ViewContainer's: https://eufemia.dnb.no/uilib/extensions/forms/Iterate/ViewContainer/demos/

We will get an additional approval from Hens tomorrow.

👁️ PR Example.

@tujoworker tujoworker requested a review from langz November 7, 2024 14:10
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 9:42pm

Copy link

codesandbox-ci bot commented Nov 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually it looks good too me, but let Jens decide 🙏

@tujoworker tujoworker merged commit f45aa4a into main Nov 8, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/card-nested branch November 8, 2024 11:41
tujoworker pushed a commit that referenced this pull request Nov 8, 2024
## [10.55.0](v10.54.1...v10.55.0) (2024-11-08)

### ⚡ Refactoring

* center cards on ultra-wide monitors and fix capitalization typo ([#4214](#4214)) ([0ec1388](0ec1388))

### 📝 Documentation

* **CountryFlag:** `iso` defaults to `NO` ([#4234](#4234)) ([cab3c32](cab3c32))
* display all Value components in the Value menu ([#4231](#4231)) ([d260a9c](d260a9c))

### 🐛 Bug Fixes

* ensure components having `fieldset` inside still can use spacing ([#4236](#4236)) ([d4e4334](d4e4334))
* **Forms:** add Iterate support for Field.PostalCodeAndCity when using `country` with a path ([#4215](#4215)) ([6f80ed9](6f80ed9)), closes [#4200](#4200)
* **Forms:** ensure `Field.Number` with `percent` and without a value renders correctly ([#4230](#4230)) ([96fa2a5](96fa2a5)), closes [#4228](#4228)
* **Forms:** fix vertical gap between Field.ArraySelection toggle buttons with checkbox variant ([#4217](#4217)) ([83f0b37](83f0b37))
* **Forms:** remove extra space from Value.* components with `inline` property ([#4246](#4246)) ([8b96fd1](8b96fd1))
* **Forms:** should display error underneath fields when nested inside Field.Selection or Field.ArraySelection   ([#4225](#4225)) ([c0f1a02](c0f1a02))
* remove legacy `fieldset` reset ([#4237](#4237)) ([a2f368b](a2f368b))
* **Upload:** alignment when displaying single DL item ([#4210](#4210)) ([5f745f5](5f745f5))
* **Upload:** fix `UploadFile` type to include `id` as required ([#4218](#4218)) ([b24fdfd](b24fdfd))

### ✨ Features

* **Card:** add style for nested cards ([#4244](#4244)) ([f45aa4a](f45aa4a))
* **Card:** remove `beta` badge ([#4211](#4211)) ([67a4fbd](67a4fbd))
* **ChildrenWithAge:** add maximum possible value to joint-responsibility & daycare ([#4219](#4219)) ([9b9c517](9b9c517))
* **CountryFlag:** add iso to properties table ([#4232](#4232)) ([9dc57cb](9dc57cb))
* **DatePicker:** Convert to functional components with typescript and hooks ([#2799](#2799)) ([45687ea](45687ea))
* **Forms:** add `layoutOptions` for enhanced horizontal label layout ([#4208](#4208)) ([8d84d97](8d84d97))
* **Forms:** add `transformLabel` to Value.Composition ([#4207](#4207)) ([c966bc1](c966bc1))
* **Forms:** add `Value.Upload` component ([#4233](#4233)) ([3adddac](3adddac))
* **Forms:** add EditButton, CancelButton and DoneButton to Form.Section containers ([#4223](#4223)) ([092abcd](092abcd))
* **ListFormat:** add `ListFormat` component ([#4238](#4238)) ([63613f1](63613f1))
* **Upload:** add `download` prop to enable file downloads instead of opening in a new tab ([#4213](#4213)) ([3e92934](3e92934))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants