fix(HeightAnimation): enhance calculation of height #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
joakbjerk
previously approved these changes
Feb 27, 2024
joakbjerk
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Wait I missclicked the approve button 😅 the keep in DOM does not seem to work anymore
tujoworker
force-pushed
the
fix/height-animation-calculation
branch
from
46eba6b to
943ab71
Compare
|
Nice 👍 can you have a new look? |
tujoworker
force-pushed
the
fix/height-animation-calculation
branch
from
943ab71 to
f57bca1
Compare
joakbjerk
approved these changes
Feb 28, 2024
packages/dnb-eufemia/src/components/height-animation/HeightAnimationInstance.ts
Outdated
Show resolved
Hide resolved
tujoworker
force-pushed
the
fix/height-animation-calculation
branch
from
f57bca1 to
6b1c27a
Compare
tujoworker
pushed a commit
that referenced
this pull request
Feb 28, 2024
## [10.22.0](v10.21.0...v10.22.0) (2024-02-28) ### 📝 Documentation * **GlobalStatus:** update number of statuses ([#3334](#3334)) ([092aa25](092aa25)) ### 🐛 Bug Fixes * **Blockquote:** Reduce padding-bottom for tablet and desktop (Sbanken) ([#3340](#3340)) ([af0d901](af0d901)) * **Breadcrumb:** variant multiple no longer same as default ([#3345](#3345)) ([ac708e0](ac708e0)) * **Card:** fix overflow/scroll issue on small screen widths ([#3341](#3341)) ([a0d4a10](a0d4a10)) * **Form.ButtonRow:** add support for correct auto placement below a Card ([#3337](#3337)) ([ced0bd7](ced0bd7)) * **Form.useData:** add support for StrictMode ([#3348](#3348)) ([d905e54](d905e54)) * **FormLabel:** align width to fit content instead of being stretched 100% on clickable labels ([#3338](#3338)) ([c7f1a4a](c7f1a4a)) * **HeightAnimation:** enhance calculation of height ([#3335](#3335)) ([e1a9859](e1a9859)) * **ProgressIndicator:** align label spacing when size is `small` and use span instead of divs to support inline elements ([#3344](#3344)) ([196bc7f](196bc7f)) ### ✨ Features * **Button, Theme:** style on dark background ([#3339](#3339)) ([29e6549](29e6549)) * **debounceAsync:** add async debounce function support ([#3343](#3343)) ([9759275](9759275)) * **Table:** accordion multiple rows and Sbanken styling ([#3289](#3289)) ([e7b7c5f](e7b7c5f)) * **TypeScript:** upgrade internal TypeScript version with a few alignments ([#3350](#3350)) ([047f81a](047f81a))
|
🎉 This PR is included in version 10.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
position: absoluteon the first pain styles, we got a wrong height calculation.