Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Expiry): validation logic #3216

Merged
merged 6 commits into from
Jan 12, 2024
Merged

fix(Expiry): validation logic #3216

merged 6 commits into from
Jan 12, 2024

Conversation

joakbjerk
Copy link
Contributor

solves #3128

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 6:31am

Copy link

codesandbox-ci bot commented Jan 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e48b40e:

Sandbox Source
eufemia-starter Configuration

@joakbjerk joakbjerk changed the title fix(Expiry): Validation logic fix(Expiry): validation logic Jan 12, 2024
@joakbjerk joakbjerk merged commit beff8e8 into main Jan 12, 2024
10 checks passed
@joakbjerk joakbjerk deleted the fix/expiry-required-logic branch January 12, 2024 10:53
tujoworker pushed a commit that referenced this pull request Jan 16, 2024
## [10.18.0](v10.17.0...v10.18.0) (2024-01-16)

### ✨ Features

* **Form.useData:** add hook to get forms data outside of the context ([#3218](#3218)) ([58c77cd](58c77cd))

### 🐛 Bug Fixes

* **Expiry:** validation logic ([#3216](#3216)) ([beff8e8](beff8e8))
* **Field.Expiry:** correct disabled styling ([#3215](#3215)) ([2a0651a](2a0651a))
* **Field.Number:** use default size ([#3229](#3229)) ([348f3cb](348f3cb))
* **Field.PhoneNumber:** ensure data value is used when given ([#3222](#3222)) ([1e37cf6](1e37cf6))
* **NumberFormat:** setting selectall to false will no longer select all ([#3213](#3213)) ([ab5cea2](ab5cea2))
* **ToggleButton:** add checked disabled style ([#3224](#3224)) ([c3ea6a6](c3ea6a6))
* **VisuallyHidden:** remove flex support ([#3219](#3219)) ([2fd5c41](2fd5c41))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

bug(Field.Expiry): behaves differently than other Field components when required
2 participants