-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): add table border and outline property #1739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tujoworker
force-pushed
the
feat/table-border-outline
branch
from
November 21, 2022 17:13
89330be
to
ab4eea6
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d3830da:
|
✅ DNB Eufemia Portal deploy preview ready
|
tujoworker
force-pushed
the
feat/table-border-outline
branch
from
November 21, 2022 21:03
ab4eea6
to
c7c7e10
Compare
tujoworker
force-pushed
the
feat/table-border-outline
branch
from
November 22, 2022 07:24
c7c7e10
to
a0ea248
Compare
langz
reviewed
Nov 22, 2022
langz
approved these changes
Nov 22, 2022
tujoworker
force-pushed
the
feat/table-border-outline
branch
from
November 22, 2022 11:10
a0ea248
to
d3830da
Compare
tujoworker
pushed a commit
that referenced
this pull request
Nov 22, 2022
# [9.38.0](v9.37.0...v9.38.0) (2022-11-22) ### Bug Fixes * add support to IS_SAFARI_DESKTOP for Safari v16 on macOS ([#1718](#1718)) ([54e2cba](54e2cba)) * **Anchor:** export types as AnchorAllProps and original instance ([#1715](#1715)) ([92ec784](92ec784)) * **Icons:** prevent icons from having same IDs (duplicate-id violation) ([#1714](#1714)) ([5e4079d](5e4079d)) * **Provider:** rewrite to functional component ([#1731](#1731)) ([b504d06](b504d06)) * **Table:** align odd/even modifiers with CSS nth ([#1724](#1724)) ([8bdad07](8bdad07)) ### Features * **Table:** add "fixed" prop for fixed table layouts ([#1708](#1708)) ([241ee0f](241ee0f)) * **Table:** add table "border" and "outline" property ([#1739](#1739)) ([ad63ffb](ad63ffb)) * **Table:** add Table.ScrolView to support horizontal scroll ([#1735](#1735)) ([85a4d86](85a4d86)) * **Table:** add Table.SortButton ([#1709](#1709)) ([288a8db](288a8db)) * **Table:** add TableContainer to stack tables with an outline ([#1740](#1740)) ([376ac06](376ac06)) * **Table:** add Th.HelpButton to be used in Table Headers ([#1711](#1711)) ([c142323](c142323)) * **Table:** support rowSpan ([#1733](#1733)) ([463692d](463692d)) * **Th:** add table header sortable props ([#1706](#1706)) ([c40393a](c40393a)) * **Tr:** automate odd/even and make it overridable ([#1705](#1705)) ([d73d3cb](d73d3cb)) * **Typography:** support styles for superscript and subscript elements ([#1721](#1721)) ([c2b043d](c2b043d)) * **Upload:** support files dropped on the document body ([#1719](#1719)) ([f206243](f206243))
🎉 This PR is included in version 9.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The border and outline is a new feature, while the rest of the styles, will be updated in another PR. Therefore, the borders look some-what little noticeable with the current background color.